linuxcnc blogs

fix a stupid bug in my previous commit

LIB_DIR is where we're planning to *install* the libs, not where we're
currently staging them.  We stage them always in "../lib".

(I didn't notice this because I stupidly had emc2.deb installed, so
LIB_DIR *did* indeed have the libs in it...  Third time's the charm
I guess/hope.)

• [DH] src/Makefile

fix linking when compiling for installation

When we're compiling for installation (manual installation or via the
debs), we want our executables and libraries to be linked against
our not-yet-installed libs, and we don't want our build dir in the
executables' rpath.  "rpath-link" does exactly this.

When we're compiling for run-in-place, we want our build dir in the rpath
(which also lets the linker find it), so nothing changes in this case.

• [DH] src/Makefile

link librs274 against libemcini

librs274 uses a bunch of symbols from libemcini.

Before this commit, librs274 did not link against libemcini, instead
requiring that any executable that links against librs274 also link
against libemcini, even if that executable itself did not need libemcini.

This commit rectifies the omission in librs274, and also stops linking
the rs274 executable against libemcini (since that executable does not
itself use that library).

• [DH] src/emc/rs274ngc/Submakefile
• [DH] src/emc/sai/Submakefile

avoid linking to a couple of unused libraries

• [DH] src/hal/utils/Submakefile

get rid of unneeded import

• [DH] src/emc/usr_intf/axis/scripts/axis.py

correct error message

• [DH] src/emc/rs274ngc/gcodemodule.cc

wrap long lines

• [DH] src/emc/rs274ngc/gcodemodule.cc

Remove unneeded offsetof hack

beacuse this file doesn't use offsetof(non_pod), the hack isn't needed
to avoid compiler warnings.

• [DH] src/emc/rs274ngc/gcodemodule.cc

make it easier to profile axis

• [DH] bin/profile_axis
• [DH] configs/sim/profile_axis.ini

move methods to base class

• [DH] lib/python/glnav.py
• [DH] lib/python/rs274/glcanon.py

reduce memory usage of display lists

so that the program can be displayed without rapids, there are
two display lists.  Before, the display lists were "everything"
and "everything but rapids".  However, you can get the same
ability to draw with and without rapids using two display lists
"only rapids" and "everything but rapids".  Presumably having
less stuff in display lists reduces load time and memory usage.

• [DH] lib/python/rs274/glcanon.py

get rid of dead code

this method was replaced by the method directly below

• [DH] lib/python/rs274/glcanon.py

make the preset view buttons react to a rotate

• [DH] src/emc/usr_intf/axis/scripts/axis.py

rotate should snap into perspective mode

this behavior was inadvertently lost with the merge of glrefactor

• [DH] lib/python/glnav.py

make my editor use the right settings

• [DH] lib/python/glnav.py
• [DH] lib/python/rs274/glcanon.py
• [DH] src/emc/rs274ngc/gcodemodule.cc

get rid of redundant code

open_file_guts does this, no need to do it here

• [DH] src/emc/usr_intf/axis/scripts/axis.py

simplify since it's always OK to call extents_info

• [DH] lib/python/rs274/glcanon.py

make it always legal to call extents_info

• [DH] lib/python/rs274/glcanon.py

a redraw is required after the rotation changes

• [DH] src/emc/usr_intf/axis/scripts/axis.py

fix display of origin when rotated

the origin rotation can't be inside the display list, because the
rotation varies

• [DH] lib/python/rs274/glcanon.py

remove redundant method

this method is defined in the base class, Translated.

• [DH] lib/python/rs274/glcanon.py

remove unneeded initializations

these fields will be initialized by the first call to set_origin_offsets
or set_xy_rotation, so these statements were not needed

• [DH] lib/python/rs274/glcanon.py
• [DH] lib/python/rs274/interpret.py

Merge remote branch 'origin/v2.4_branch'

Conflicts:
	src/emc/usr_intf/axis/scripts/axis.py

• [DH] src/emc/usr_intf/stepconf/stepconf.py

fix a memory leak

By binding a method of AxisCanon, the instance becomes
uncollectable.  This reformulation still has a small leak
(one Tkinter command binding) but it is not the several
megabytes that leaking an AxisCanon could cause.

• [DH] src/emc/usr_intf/axis/scripts/axis.py

fix a memory leak

By binding a method of AxisCanon, the instance becomes
uncollectable.  This reformulation still has a small leak
(one Tkinter command binding) but it is not the several
megabytes that leaking an AxisCanon could cause.

• [DH] src/emc/usr_intf/axis/scripts/axis.py

add static qualifiers where appropriate

• [DH] src/emc/rs274ngc/gcodemodule.cc

get rid of unneeded declarations

• [DH] src/emc/rs274ngc/gcodemodule.cc

get rid of unused variable

• [DH] src/emc/rs274ngc/gcodemodule.cc

get rid of some emc1-compatibility defines

• [DH] src/emc/rs274ngc/gcodemodule.cc

simplify maybe_new_line with default argument

Based on a patch from Alexey Starikovskiy <astarikovskiy@suse.de>

• [DH] src/emc/rs274ngc/gcodemodule.cc

avoid extra work when there's no rotation

Based on a patch from Alexey Starikovskiy <astarikovskiy@suse.de>

• [DH] lib/python/rs274/interpret.py

avoid unneeded work when sequence_number is unchanged

Based on a patch from Alexey Starikovskiy <astarikovskiy@suse.de>

• [DH] src/emc/rs274ngc/gcodemodule.cc

Fix period, maxvel calculations in axis test

The calculations of period and maxvel must account for systems with
long steplen values.

Closes SF#2924185, SF#2924173

• [DH] src/emc/usr_intf/stepconf/stepconf.py